Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chrome/browser/ui/certificate_dialogs.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | trunk/src/chrome/browser/ui/webui/print_preview/print_preview_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/ui/certificate_dialogs.cc
===================================================================
--- trunk/src/chrome/browser/ui/certificate_dialogs.cc (revision 239920)
+++ trunk/src/chrome/browser/ui/certificate_dialogs.cc (working copy)
@@ -49,7 +49,11 @@
std::string GetBase64String(net::X509Certificate::OSCertHandle cert) {
std::string base64;
- base::Base64Encode(x509_certificate_model::GetDerString(cert), &base64);
+ if (!base::Base64Encode(
+ x509_certificate_model::GetDerString(cert), &base64)) {
+ LOG(ERROR) << "base64 encoding error";
+ return std::string();
+ }
return "-----BEGIN CERTIFICATE-----\r\n" +
WrapAt64(base64) +
"-----END CERTIFICATE-----\r\n";
« no previous file with comments | « trunk/src/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | trunk/src/chrome/browser/ui/webui/print_preview/print_preview_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698