Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chrome/browser/metrics/metrics_log_serializer.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/browser/metrics/metrics_log.cc ('k') | trunk/src/chrome/browser/metrics/variations/variations_http_header_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/metrics/metrics_log_serializer.cc
===================================================================
--- trunk/src/chrome/browser/metrics/metrics_log_serializer.cc (revision 239920)
+++ trunk/src/chrome/browser/metrics/metrics_log_serializer.cc (working copy)
@@ -141,7 +141,10 @@
it != local_list.end(); ++it) {
// We encode the compressed log as Value::CreateStringValue() expects to
// take a valid UTF8 string.
- base::Base64Encode(it->log_text(), &encoded_log);
+ if (!base::Base64Encode(it->log_text(), &encoded_log)) {
+ list->Clear();
+ return;
+ }
base::MD5Update(&ctx, encoded_log);
list->Append(Value::CreateStringValue(encoded_log));
}
« no previous file with comments | « trunk/src/chrome/browser/metrics/metrics_log.cc ('k') | trunk/src/chrome/browser/metrics/variations/variations_http_header_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698