Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chrome/browser/extensions/install_signer.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/browser/extensions/extension_protocols.cc ('k') | trunk/src/chrome/browser/internal_auth.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/extensions/install_signer.cc
===================================================================
--- trunk/src/chrome/browser/extensions/install_signer.cc (revision 239920)
+++ trunk/src/chrome/browser/extensions/install_signer.cc (working copy)
@@ -115,8 +115,7 @@
std::string result_bytes(crypto::kSHA256Length, 0);
hash->Finish(string_as_array(&result_bytes), result_bytes.size());
- base::Base64Encode(result_bytes, result);
- return true;
+ return base::Base64Encode(result_bytes, result);
}
} // namespace
« no previous file with comments | « trunk/src/chrome/browser/extensions/extension_protocols.cc ('k') | trunk/src/chrome/browser/internal_auth.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698