trunk/src/chrome/browser/extensions/api/identity/web_auth_flow.cc - Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: trunk/src/chrome/browser/extensions/api/identity/web_auth_flow.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: trunk/src/chrome/browser/extensions/api/identity/web_auth_flow.cc

===================================================================

--- trunk/src/chrome/browser/extensions/api/identity/web_auth_flow.cc (revision 239920)

+++ trunk/src/chrome/browser/extensions/api/identity/web_auth_flow.cc (working copy)

@@ -76,7 +76,8 @@

// in OnShellWindowAdded.

std::string random_bytes;

crypto::RandBytes(WriteInto(&random_bytes, 33), 32);

- base::Base64Encode(random_bytes, &shell_window_key_);

+ bool success = base::Base64Encode(random_bytes, &shell_window_key_);

+ DCHECK(success);

// identityPrivate.onWebFlowRequest(shell_window_key, provider_url_, mode_)

scoped_ptr<base::ListValue> args(new base::ListValue());