Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: trunk/src/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
===================================================================
--- trunk/src/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc (revision 239920)
+++ trunk/src/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc (working copy)
@@ -371,7 +371,11 @@
}
std::string encoded_response;
- base::Base64Encode(response, &encoded_response);
+ if (!base::Base64Encode(response, &encoded_response)) {
+ SetError(kResponseBadBase64Error);
+ SendResponse(false);
+ return;
+ }
results_ = api_epkp::ChallengeMachineKey::Results::Create(encoded_response);
SendResponse(true);
@@ -540,7 +544,11 @@
}
std::string encoded_response;
- base::Base64Encode(response, &encoded_response);
+ if (!base::Base64Encode(response, &encoded_response)) {
+ SetError(kResponseBadBase64Error);
+ SendResponse(false);
+ return;
+ }
results_ = api_epkp::ChallengeUserKey::Results::Create(encoded_response);
SendResponse(true);

Powered by Google App Engine
This is Rietveld 408576698