Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chrome/browser/devtools/adb/android_rsa.cc

Issue 101113004: Revert 239759 "The comment in base64.h implies that base::Base64..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/browser/chromeos/settings/device_settings_cache.cc ('k') | trunk/src/chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/devtools/adb/android_rsa.cc
===================================================================
--- trunk/src/chrome/browser/devtools/adb/android_rsa.cc (revision 239920)
+++ trunk/src/chrome/browser/devtools/adb/android_rsa.cc (working copy)
@@ -196,9 +196,10 @@
return NULL;
std::string key_string(key_info.begin(), key_info.end());
- base::Base64Encode(key_string, &encoded_key);
- profile->GetPrefs()->SetString(prefs::kDevToolsAdbKey,
- encoded_key);
+ if (base::Base64Encode(key_string, &encoded_key)) {
+ profile->GetPrefs()->SetString(prefs::kDevToolsAdbKey,
+ encoded_key);
+ }
}
return key.release();
}
« no previous file with comments | « trunk/src/chrome/browser/chromeos/settings/device_settings_cache.cc ('k') | trunk/src/chrome/browser/extensions/api/developer_private/developer_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698