Revert 239759 "The comment in base64.h implies that base::Base64..."

trunk/src/remoting/protocol/v2_authenticator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/v2_authenticator.h"
 
 #include "base/base64.h"
 #include "base/logging.h"
 #include "remoting/base/constants.h"
 #include "remoting/base/rsa_key_pair.h"
@@ skipping 138 matching lines @@
 
 scoped_ptr<buzz::XmlElement> V2Authenticator::GetNextMessage() {
   DCHECK_EQ(state(), MESSAGE_READY);
 
   scoped_ptr<buzz::XmlElement> message = CreateEmptyAuthenticatorMessage();
 
   DCHECK(!pending_messages_.empty());
   while (!pending_messages_.empty()) {
     const std::string& spake_message = pending_messages_.front();
     std::string base64_message;
-    base::Base64Encode(spake_message, &base64_message);
+    if (!base::Base64Encode(spake_message, &base64_message)) {
+      LOG(DFATAL) << "Cannot perform base64 encode on certificate";
+      continue;
+    }
 
     buzz::XmlElement* eke_tag = new buzz::XmlElement(kEkeTag);
     eke_tag->SetBodyText(base64_message);
     message->AddElement(eke_tag);
 
     pending_messages_.pop();
   }
 
   if (!local_cert_.empty() && !certificate_sent_) {
     buzz::XmlElement* certificate_tag = new buzz::XmlElement(kCertificateTag);
     std::string base64_cert;
-    base::Base64Encode(local_cert_, &base64_cert);
+    if (!base::Base64Encode(local_cert_, &base64_cert)) {
+      LOG(DFATAL) << "Cannot perform base64 encode on certificate";
+    }
     certificate_tag->SetBodyText(base64_cert);
     message->AddElement(certificate_tag);
     certificate_sent_ = true;
   }
 
   if (state_ != ACCEPTED) {
     state_ = WAITING_MESSAGE;
   }
   return message.Pass();
 }
@@ skipping 13 matching lines @@
             remote_cert_, auth_key_).Pass());
   }
 }
 
 bool V2Authenticator::is_host_side() const {
   return local_key_pair_.get() != NULL;
 }
 
 }  // namespace protocol
 }  // namespace remoting