Revert 239759 "The comment in base64.h implies that base::Base64..."

trunk/src/remoting/protocol/auth_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/auth_util.h"
 
 #include "base/base64.h"
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "crypto/hmac.h"
 #include "crypto/sha2.h"
 #include "net/base/net_errors.h"
 #include "net/socket/ssl_socket.h"
 
 namespace remoting {
 namespace protocol {
 
 const char kClientAuthSslExporterLabel[] =
     "EXPORTER-remoting-channel-auth-client";
 const char kHostAuthSslExporterLabel[] =
     "EXPORTER-remoting-channel-auth-host";
 
 const char kSslFakeHostName[] = "chromoting";
 
 std::string GenerateSupportAuthToken(const std::string& jid,
                                      const std::string& access_code) {
   std::string sha256 = crypto::SHA256HashString(jid + " " + access_code);
   std::string sha256_base64;
-  base::Base64Encode(sha256, &sha256_base64);
+  if (!base::Base64Encode(sha256, &sha256_base64)) {
+    LOG(FATAL) << "Failed to encode auth token";
+  }
   return sha256_base64;
 }
 
 bool VerifySupportAuthToken(const std::string& jid,
                             const std::string& access_code,
                             const std::string& auth_token) {
   std::string expected_token =
       GenerateSupportAuthToken(jid, access_code);
   return expected_token == auth_token;
 }
@@ skipping 21 matching lines @@
   if (!response.Sign(shared_secret, out_bytes, kAuthDigestLength)) {
     NOTREACHED() << "HMAC::Sign failed";
     return std::string();
   }
 
   return std::string(out_bytes, out_bytes + kAuthDigestLength);
 }
 
 }  // namespace protocol
 }  // namespace remoting