Revert 239759 "The comment in base64.h implies that base::Base64..."

trunk/src/net/websockets/websocket_handshake_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/websockets/websocket_handshake_handler.h"
 
 #include <limits>
 
 #include "base/base64.h"
 #include "base/sha1.h"
@@ skipping 333 matching lines @@
   return original_header_length_ > 0 &&
       static_cast<size_t>(original_header_length_) <= original_.size();
 }
 
 void ComputeSecWebSocketAccept(const std::string& key,
                                std::string* accept) {
   DCHECK(accept);
 
   std::string hash =
       base::SHA1HashString(key + websockets::kWebSocketGuid);
-  base::Base64Encode(hash, accept);
+  bool encode_success = base::Base64Encode(hash, accept);
+  DCHECK(encode_success);
 }
 
 bool WebSocketHandshakeResponseHandler::ParseResponseInfo(
     const HttpResponseInfo& response_info,
     const std::string& challenge) {
   if (!response_info.headers.get())
     return false;
 
   // TODO(ricea): Eliminate all the reallocations and string copies.
   std::string response_message;
@@ skipping 32 matching lines @@
   if (spdy_protocol_version <= 2)
     status = headers.find("status");
   else
     status = headers.find(":status");
   if (status == headers.end())
     return false;
 
   std::string hash =
       base::SHA1HashString(challenge + websockets::kWebSocketGuid);
   std::string websocket_accept;
-  base::Base64Encode(hash, &websocket_accept);
+  bool encode_success = base::Base64Encode(hash, &websocket_accept);
+  DCHECK(encode_success);
 
   std::string response_message = base::StringPrintf(
       "%s %s\r\n", websockets::kHttpProtocolVersion, status->second.c_str());
 
   AppendHeader(
       websockets::kUpgrade, websockets::kWebSocketLowercase, &response_message);
   AppendHeader(
       HttpRequestHeaders::kConnection, websockets::kUpgrade, &response_message);
   AppendHeader(
       websockets::kSecWebSocketAccept, websocket_accept, &response_message);
@@ skipping 71 matching lines @@
 
 std::string WebSocketHandshakeResponseHandler::GetResponse() {
   DCHECK(HasResponse());
   DCHECK(!status_line_.empty());
   // headers_ might be empty for wrong response from server.
 
   return status_line_ + headers_ + header_separator_;
 }
 
 }  // namespace net