Revert 239759 "The comment in base64.h implies that base::Base64..."

trunk/src/net/websockets/websocket_basic_handshake_stream.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/websockets/websocket_basic_handshake_stream.h"
 
 #include <algorithm>
 #include <iterator>
 
 #include "base/base64.h"
@@ skipping 15 matching lines @@
 #include "net/websockets/websocket_handshake_handler.h"
 #include "net/websockets/websocket_stream.h"
 
 namespace net {
 namespace {
 
 std::string GenerateHandshakeChallenge() {
   std::string raw_challenge(websockets::kRawChallengeLength, '\0');
   crypto::RandBytes(string_as_array(&raw_challenge), raw_challenge.length());
   std::string encoded_challenge;
-  base::Base64Encode(raw_challenge, &encoded_challenge);
+  bool encode_success = base::Base64Encode(raw_challenge, &encoded_challenge);
+  DCHECK(encode_success);
   return encoded_challenge;
 }
 
 void AddVectorHeaderIfNonEmpty(const char* name,
                                const std::vector<std::string>& value,
                                HttpRequestHeaders* headers) {
   if (value.empty())
     return;
   headers->SetHeader(name, JoinString(value, ", "));
 }
@@ skipping 258 matching lines @@
       headers->HasHeaderValue(HttpRequestHeaders::kConnection,
                               websockets::kUpgrade) &&
       ValidateSubProtocol(headers, requested_sub_protocols_, &sub_protocol_) &&
       ValidateExtensions(headers, requested_extensions_, &extensions_)) {
     return OK;
   }
   return ERR_INVALID_RESPONSE;
 }
 
 }  // namespace net