Revert 239759 "The comment in base64.h implies that base::Base64..."

trunk/src/chrome/browser/metrics/variations/variations_service.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/metrics/variations/variations_service.h"
 
 #include <set>
 
 #include "base/base64.h"
 #include "base/build_time.h"
@@ skipping 463 matching lines @@
 
   // Only store the seed data if it parses correctly.
   VariationsSeed seed;
   if (!seed.ParseFromString(seed_data)) {
     VLOG(1) << "Variations Seed data from server is not in valid proto format, "
             << "rejecting the seed.";
     return false;
   }
 
   std::string base64_seed_data;
-  base::Base64Encode(seed_data, &base64_seed_data);
+  if (!base::Base64Encode(seed_data, &base64_seed_data)) {
+    VLOG(1) << "Variations Seed data from server fails Base64Encode, rejecting "
+            << "the seed.";
+    return false;
+  }
 
   local_state_->SetString(prefs::kVariationsSeed, base64_seed_data);
   local_state_->SetString(prefs::kVariationsSeedHash, HashSeed(seed_data));
   local_state_->SetInt64(prefs::kVariationsSeedDate,
                          seed_date.ToInternalValue());
   variations_serial_number_ = seed.serial_number();
 
   RecordLastFetchTime();
 
   return true;
@@ skipping 29 matching lines @@
 
 void VariationsService::RecordLastFetchTime() {
   // local_state_ is NULL in tests, so check it first.
   if (local_state_) {
     local_state_->SetInt64(prefs::kVariationsLastFetchTime,
                            base::Time::Now().ToInternalValue());
   }
 }
 
 }  // namespace chrome_variations