Issue 101113002: Compile libaddressinput on Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101113002: Compile libaddressinput on Mac. (Closed)

Created:
7 years ago by Dan Beam

Modified:
7 years ago

Reviewers:
please use gerrit instead

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Compile libaddressinput on Mac. All new symbols need to be in an .order file on Mac but because libaddressinput is built statically it doesn't need to export symbols at all, so remove this from its gyp file. R=rouslan@chromium.org BUG=317837 TEST=mac compiles when we actually start using libaddressinput in chrome Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238372

Patch Set 1 : . #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	third_party/libaddressinput/libaddressinput.gyp	View		1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/101113002/20001

7 years ago (2013-12-03 06:22:49 UTC) #3

Message was sent while issue was closed.

Change committed as 238372

Expand Messages | Collapse Messages