Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(706)

Issue 1011123002: [turbofan] Follow-up to evaluation order in AstGraphBuilder. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_issue-cr-467531
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Follow-up to evaluation order in AstGraphBuilder. The evaluation order of receiver versus arguments is not properly defined by C++. This caused issues with Clang where the environment changed after the receiveing environment was already loaded. R=jarin@chromium.org BUG=chromium:467531 LOG=N Committed: https://crrev.com/7f7cff33f37a05eea357c170a9aea03484a6dc94 Cr-Commit-Position: refs/heads/master@{#27240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-17 13:15:03 UTC) #1
Jarin
lgtm
5 years, 9 months ago (2015-03-17 13:30:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011123002/1
5 years, 9 months ago (2015-03-17 13:35:47 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 14:08:09 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 14:08:33 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f7cff33f37a05eea357c170a9aea03484a6dc94
Cr-Commit-Position: refs/heads/master@{#27240}

Powered by Google App Engine
This is Rietveld 408576698