Fix potential bug in FastSharedBufferReader::getConsecutiveData

Source/platform/image-decoders/FastSharedBufferReader.h

 /*
  * Copyright (C) 2015 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 52 matching lines @@
     {
         return *getConsecutiveData(dataPosition, 1, 0);
     }
 
     size_t size() const
     {
         return m_data->size();
     }
 
 private:
+    void getSomeDataIntoCache(unsigned dataPosition);

[Peter Kasting, 2015/03/26 19:37:08]

Nit: getSomeDataInternal() might be a better name, since the functions of
getSomeData() and this are basically identical other than the return values, and
"IntoCache" isn't instantly clear to me as a reader.

[kbalazs, 2015/03/26 20:33:11]

Acknowledged.

+
     RefPtr<SharedBuffer> m_data;
 
     // Caches the last segment of |m_data| accessed, since subsequent reads are
     // likely to re-access it.
     const char* m_segment;
     size_t m_segmentLength;
 
-    // Data position in |m_data| pointed by |m_segment|.
+    // Data position in |m_data| pointed by |segment|.

[Peter Kasting, 2015/03/26 19:37:08]

Nit: pointed -> pointed to

[kbalazs, 2015/03/26 20:33:11]

Ah, I didn't mean to change it. Originally it was saying "Data position in
|m_data| pointed by |m_segment|" which is correct since m_segment points into
m_data. I'm gonna change back.

     size_t m_dataPosition;
 };
 
 } // namespace blink
 
 #endif