Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1011103003: [Turbofan] Only weaken types for Phi nodes. (Closed)

Created:
5 years, 9 months ago by Jarin
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Only weaken types for Phi nodes. We also need to fix the weakening to weaken unions with ranges in them. BUG= Committed: https://crrev.com/46d6ffeddd960db5ab1a2c2fd8a05436c734e047 Cr-Commit-Position: refs/heads/master@{#27257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/compiler/typer.cc View 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
How about this?
5 years, 9 months ago (2015-03-17 13:00:44 UTC) #2
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-18 09:22:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011103003/1
5 years, 9 months ago (2015-03-18 09:22:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 09:25:46 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 09:26:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46d6ffeddd960db5ab1a2c2fd8a05436c734e047
Cr-Commit-Position: refs/heads/master@{#27257}

Powered by Google App Engine
This is Rietveld 408576698