tools/metrics/histograms/histograms.xml - Issue 1011093004: metrics: log whether drives have seek penalties (and whether this was determined successfully).

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1011093004: metrics: log whether drives have seek penalties (and whether this was determined successfully). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ssd2

Patch Set: times Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 45ab30df9b7a9c0adbc0687ca07a10bb6f9da82f..10efcc6d933c557f2ad44f9febb28c77c23c62a8 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -10982,6 +10982,28 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Hardware.Drive.HasSeekPenalty" enum="BooleanHasSeekPenalty">

+ <owner>dbeam@chromium.org</owner>

+ <summary>

+ Whether a drive has a seek penalty (i.e. is a spinning disk).

Mark P 2015/03/18 18:17:43 All histograms should mention when they're recorde

Dan Beam 2015/03/18 18:33:51 Done.

+ </summary>

+</histogram>

+<histogram name="Hardware.Drive.HasSeekPenalty_Success" enum="BooleanSuccess">

+ <owner>dbeam@chromium.org</owner>

+ <summary>

+ Whether it was possible to determine whether a drive has a seek penalty.

+ This can fail when drivers don't offer this information.

Mark P 2015/03/18 18:17:43 drivers? drives?

Dan Beam 2015/03/18 18:33:51 actually meant drivers but technically both are co

+ </summary>

+</histogram>

+<histogram name="Hardware.Drive.HasSeekPenalty_Time" units="milliseconds">

+ <owner>dbeam@chromium.org</owner>

+ <summary>

+ The amount of time it takes to determine whether a drive has a seek penalty.

+ </summary>

+</histogram>

<histogram name="HIDDetection.OOBEDevicesDetectedOnContinuePressed"

enum="HIDContinueScenarioType">

<owner>merkulova@chromium.org</owner>

@@ -45103,6 +45125,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</enum>

+<enum name="BooleanHasSeekPenalty" type="int">

+ <int value="0" label="Has no seek penalty (e.g. is flash memory)"/>

+ <int value="1" label="Has seek penalty (e.g. spinning disk)"/>

+</enum>

« no previous file with comments | « chrome/browser/metrics/drive_metrics_provider.cc ('k') | no next file » | no next file with comments »