Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 1011093004: metrics: log whether drives have seek penalties (and whether this was determined successfully). (Closed)

Created:
5 years, 9 months ago by Dan Beam
Modified:
5 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ssd2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

metrics: log whether drives have seek penalties (and whether this was determined successfully). R=asvitkine@chromium.org BUG=463209 Committed: https://crrev.com/9c09b08ce98ae3e25b2c3b248aa642eb2bff178c Cr-Commit-Position: refs/heads/master@{#321257}

Patch Set 1 : times #

Total comments: 4

Patch Set 2 : better histograms.xml comments #

Total comments: 4

Patch Set 3 : mpearson@ review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M chrome/browser/metrics/drive_metrics_provider.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
Dan Beam
asvitkine@: is this what you had in mind?
5 years, 9 months ago (2015-03-18 00:01:35 UTC) #3
Dan Beam
-asvitkine@ (ooo), +mpearson@ mpearson@: though the code lives in a metrics provider, it's just UMA_* ...
5 years, 9 months ago (2015-03-18 18:11:33 UTC) #8
Mark P
https://codereview.chromium.org/1011093004/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1011093004/diff/80001/tools/metrics/histograms/histograms.xml#newcode10988 tools/metrics/histograms/histograms.xml:10988: + Whether a drive has a seek penalty (i.e. ...
5 years, 9 months ago (2015-03-18 18:17:43 UTC) #9
Dan Beam
https://codereview.chromium.org/1011093004/diff/80001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1011093004/diff/80001/tools/metrics/histograms/histograms.xml#newcode10988 tools/metrics/histograms/histograms.xml:10988: + Whether a drive has a seek penalty (i.e. ...
5 years, 9 months ago (2015-03-18 18:33:52 UTC) #12
Mark P
https://codereview.chromium.org/1011093004/diff/140001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1011093004/diff/140001/tools/metrics/histograms/histograms.xml#newcode10989 tools/metrics/histograms/histograms.xml:10989: + shortly after startup when constructing the initial UMA ...
5 years, 9 months ago (2015-03-18 18:45:46 UTC) #13
Dan Beam
https://codereview.chromium.org/1011093004/diff/140001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1011093004/diff/140001/tools/metrics/histograms/histograms.xml#newcode10989 tools/metrics/histograms/histograms.xml:10989: + shortly after startup when constructing the initial UMA ...
5 years, 9 months ago (2015-03-18 19:19:42 UTC) #14
Mark P
lgtm
5 years, 9 months ago (2015-03-18 19:32:52 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011093004/160001
5 years, 9 months ago (2015-03-18 22:43:31 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:160001)
5 years, 9 months ago (2015-03-19 00:52:39 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9c09b08ce98ae3e25b2c3b248aa642eb2bff178c Cr-Commit-Position: refs/heads/master@{#321257}
5 years, 9 months ago (2015-03-19 00:53:40 UTC) #19
Alexei Svitkine (slow)
5 years, 8 months ago (2015-03-30 20:06:45 UTC) #21
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698