Source/bindings/tests/results/modules/V8TestInterface5.cpp - Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/modules/V8TestInterface5.cpp

Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing after review comments! :) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestTypedefs.cpp ('k') | Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/modules/V8TestInterface5.cpp

diff --git a/Source/bindings/tests/results/modules/V8TestInterface5.cpp b/Source/bindings/tests/results/modules/V8TestInterface5.cpp

index 4ff63d05f5490e2997502945db20e53ab6be06ca..c1e68afd5e2a471e1c92166e41a33fce56c195fb 100644

--- a/Source/bindings/tests/results/modules/V8TestInterface5.cpp

+++ b/Source/bindings/tests/results/modules/V8TestInterface5.cpp

@@ -265,7 +265,7 @@ static void alwaysExposedAttributeAttributeSetter(v8::Local<v8::Value> v8Value,

v8::Local<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "alwaysExposedAttribute", "TestInterface5", holder, info.GetIsolate());

TestInterface5Implementation* impl = V8TestInterface5::toImpl(holder);

- int cppValue = toInt32(info.GetIsolate(), v8Value, exceptionState);

+ int cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

if (exceptionState.throwIfNeeded())

return;

impl->setAlwaysExposedAttribute(cppValue);

@@ -297,7 +297,7 @@ static void workerExposedAttributeAttributeSetter(v8::Local<v8::Value> v8Value,

v8::Local<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "workerExposedAttribute", "TestInterface5", holder, info.GetIsolate());

TestInterface5Implementation* impl = V8TestInterface5::toImpl(holder);

- int cppValue = toInt32(info.GetIsolate(), v8Value, exceptionState);

+ int cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

if (exceptionState.throwIfNeeded())

return;

impl->setWorkerExposedAttribute(cppValue);

@@ -329,7 +329,7 @@ static void windowExposedAttributeAttributeSetter(v8::Local<v8::Value> v8Value,

v8::Local<v8::Object> holder = info.Holder();

ExceptionState exceptionState(ExceptionState::SetterContext, "windowExposedAttribute", "TestInterface5", holder, info.GetIsolate());

TestInterface5Implementation* impl = V8TestInterface5::toImpl(holder);

- int cppValue = toInt32(info.GetIsolate(), v8Value, exceptionState);

+ int cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

if (exceptionState.throwIfNeeded())

return;

impl->setWindowExposedAttribute(cppValue);