Source/bindings/tests/results/core/V8TestInterface2.cpp - Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterface2.cpp

Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Patch for landing after review comments! :) Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterface.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterface2.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterface2.cpp b/Source/bindings/tests/results/core/V8TestInterface2.cpp

index 7304fc81c0e1c9af7402879ccde6789dc2195210..1d1c8244157785ccff97cd461876915047aa8d57 100644

--- a/Source/bindings/tests/results/core/V8TestInterface2.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterface2.cpp

@@ -47,7 +47,7 @@ static void itemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

TestInterface2* impl = V8TestInterface2::toImpl(info.Holder());

unsigned index;

{

- index = toUInt32(info.GetIsolate(), info[0], exceptionState);

+ index = toUInt32(info.GetIsolate(), info[0], NormalConversion, exceptionState);

if (exceptionState.throwIfNeeded())

return;

}

@@ -78,7 +78,7 @@ static void setItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

unsigned index;

TestInterfaceEmpty* value;

{

- index = toUInt32(info.GetIsolate(), info[0], exceptionState);

+ index = toUInt32(info.GetIsolate(), info[0], NormalConversion, exceptionState);

if (exceptionState.throwIfNeeded())

return;

value = V8TestInterfaceEmpty::toImplWithTypeCheck(info.GetIsolate(), info[1]);

@@ -114,7 +114,7 @@ static void deleteItemMethod(const v8::FunctionCallbackInfo<v8::Value>& info)

TestInterface2* impl = V8TestInterface2::toImpl(info.Holder());

unsigned index;

{

- index = toUInt32(info.GetIsolate(), info[0], exceptionState);

+ index = toUInt32(info.GetIsolate(), info[0], NormalConversion, exceptionState);

if (exceptionState.throwIfNeeded())

return;

}