Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp

Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing after review comments! :) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8BindingTest.cpp ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp
diff --git a/Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp b/Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp
index aece51bd40e5c1c34355ce8898613c59f1d94734..75cb2283302732faec75603a5d81bd2fe559cc9b 100644
--- a/Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp
+++ b/Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp
@@ -98,7 +98,9 @@ bool ParsedProperties::parseBlobPropertyBag(v8::Isolate* isolate, v8::Local<v8::
v8::Local<v8::Value> lastModified;
TONATIVE_DEFAULT(bool, containsLastModified, DictionaryHelper::get(dictionary, "lastModified", lastModified), false);
if (containsLastModified) {
- TONATIVE_DEFAULT(long long, lastModifiedInt, toInt64(isolate, lastModified), false);
+ long long lastModifiedInt = toInt64(isolate, lastModified, NormalConversion, exceptionState);
+ if (exceptionState.hadException())
+ return false;
setLastModified(static_cast<double>(lastModifiedInt));
} else {
setDefaultLastModified();
« no previous file with comments | « Source/bindings/core/v8/V8BindingTest.cpp ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698