Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing after review comments! :) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8BindingTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/V8Binding.cpp
diff --git a/Source/bindings/core/v8/V8Binding.cpp b/Source/bindings/core/v8/V8Binding.cpp
index 0f8d64c7f9f1fb2f4e19bbb1093a8014f51af597..3128eed2bb364d390f3e44345d04fa1fb58a7514 100644
--- a/Source/bindings/core/v8/V8Binding.cpp
+++ b/Source/bindings/core/v8/V8Binding.cpp
@@ -281,45 +281,21 @@ int8_t toInt8(v8::Isolate* isolate, v8::Handle<v8::Value> value, IntegerConversi
return toSmallerInt<int8_t>(isolate, value, configuration, "byte", exceptionState);
}
-int8_t toInt8(v8::Isolate* isolate, v8::Handle<v8::Value> value)
-{
- NonThrowableExceptionState exceptionState;
- return toInt8(isolate, value, NormalConversion, exceptionState);
-}
-
uint8_t toUInt8(v8::Isolate* isolate, v8::Handle<v8::Value> value, IntegerConversionConfiguration configuration, ExceptionState& exceptionState)
{
return toSmallerUInt<uint8_t>(isolate, value, configuration, "octet", exceptionState);
}
-uint8_t toUInt8(v8::Isolate* isolate, v8::Handle<v8::Value> value)
-{
- NonThrowableExceptionState exceptionState;
- return toUInt8(isolate, value, NormalConversion, exceptionState);
-}
-
int16_t toInt16(v8::Isolate* isolate, v8::Handle<v8::Value> value, IntegerConversionConfiguration configuration, ExceptionState& exceptionState)
{
return toSmallerInt<int16_t>(isolate, value, configuration, "short", exceptionState);
}
-int16_t toInt16(v8::Isolate* isolate, v8::Handle<v8::Value> value)
-{
- NonThrowableExceptionState exceptionState;
- return toInt16(isolate, value, NormalConversion, exceptionState);
-}
-
uint16_t toUInt16(v8::Isolate* isolate, v8::Handle<v8::Value> value, IntegerConversionConfiguration configuration, ExceptionState& exceptionState)
{
return toSmallerUInt<uint16_t>(isolate, value, configuration, "unsigned short", exceptionState);
}
-uint16_t toUInt16(v8::Isolate* isolate, v8::Handle<v8::Value> value)
-{
- NonThrowableExceptionState exceptionState;
- return toUInt16(isolate, value, NormalConversion, exceptionState);
-}
-
int32_t toInt32Slow(v8::Isolate* isolate, v8::Handle<v8::Value> value, IntegerConversionConfiguration configuration, ExceptionState& exceptionState)
{
ASSERT(!value->IsInt32());
@@ -349,12 +325,6 @@ int32_t toInt32Slow(v8::Isolate* isolate, v8::Handle<v8::Value> value, IntegerCo
return numberObject->Int32Value();
}
-int32_t toInt32(v8::Isolate* isolate, v8::Handle<v8::Value> value)
-{
- NonThrowableExceptionState exceptionState;
- return toInt32(isolate, value, NormalConversion, exceptionState);
-}
-
uint32_t toUInt32Slow(v8::Isolate* isolate, v8::Handle<v8::Value> value, IntegerConversionConfiguration configuration, ExceptionState& exceptionState)
{
ASSERT(!value->IsUint32());
@@ -397,12 +367,6 @@ uint32_t toUInt32Slow(v8::Isolate* isolate, v8::Handle<v8::Value> value, Integer
return numberObject->Uint32Value();
}
-uint32_t toUInt32(v8::Isolate* isolate, v8::Handle<v8::Value> value)
-{
- NonThrowableExceptionState exceptionState;
- return toUInt32(isolate, value, NormalConversion, exceptionState);
-}
-
int64_t toInt64Slow(v8::Isolate* isolate, v8::Handle<v8::Value> value, IntegerConversionConfiguration configuration, ExceptionState& exceptionState)
{
ASSERT(!value->IsInt32());
@@ -431,12 +395,6 @@ int64_t toInt64Slow(v8::Isolate* isolate, v8::Handle<v8::Value> value, IntegerCo
return integer;
}
-int64_t toInt64(v8::Isolate* isolate, v8::Handle<v8::Value> value)
-{
- NonThrowableExceptionState exceptionState;
- return toInt64(isolate, value, NormalConversion, exceptionState);
-}
-
uint64_t toUInt64Slow(v8::Isolate* isolate, v8::Handle<v8::Value> value, IntegerConversionConfiguration configuration, ExceptionState& exceptionState)
{
ASSERT(!value->IsUint32());
@@ -483,12 +441,6 @@ uint64_t toUInt64Slow(v8::Isolate* isolate, v8::Handle<v8::Value> value, Integer
return integer;
}
-uint64_t toUInt64(v8::Isolate* isolate, v8::Handle<v8::Value> value)
-{
- NonThrowableExceptionState exceptionState;
- return toUInt64(isolate, value, NormalConversion, exceptionState);
-}
-
float toRestrictedFloat(v8::Isolate* isolate, v8::Handle<v8::Value> value, ExceptionState& exceptionState)
{
float numberValue = toFloat(isolate, value, exceptionState);
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8BindingTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698