Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: Source/bindings/core/v8/V8BindingTest.cpp

Issue 1011093002: [bindings] Pass NormalConversion to to[U]Int{8/16/32/64}(...) in v8_types.py and reduce conversion … (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Patch for landing after review comments! :) Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "bindings/core/v8/V8Binding.h" 6 #include "bindings/core/v8/V8Binding.h"
7 7
8 #include "bindings/core/v8/ExceptionState.h" 8 #include "bindings/core/v8/ExceptionState.h"
9 #include "bindings/core/v8/ToV8.h" 9 #include "bindings/core/v8/ToV8.h"
10 #include "wtf/Vector.h" 10 #include "wtf/Vector.h"
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 { 70 {
71 v8::Handle<v8::Array> v8Array = v8::Array::New(m_scope.isolate(), 3); 71 v8::Handle<v8::Array> v8Array = v8::Array::New(m_scope.isolate(), 3);
72 v8Array->Set(toV8(0), toV8("Vini, vidi, vici.")); 72 v8Array->Set(toV8(0), toV8("Vini, vidi, vici."));
73 v8Array->Set(toV8(1), toV8(65535)); 73 v8Array->Set(toV8(1), toV8(65535));
74 v8Array->Set(toV8(2), toV8(0.125)); 74 v8Array->Set(toV8(2), toV8(0.125));
75 75
76 NonThrowableExceptionState exceptionState; 76 NonThrowableExceptionState exceptionState;
77 Vector<v8::Local<v8::Value>> v8HandleVector = toImplArray<v8::Local<v8:: Value>>(v8Array, 0, m_scope.isolate(), exceptionState); 77 Vector<v8::Local<v8::Value>> v8HandleVector = toImplArray<v8::Local<v8:: Value>>(v8Array, 0, m_scope.isolate(), exceptionState);
78 EXPECT_EQ(3U, v8HandleVector.size()); 78 EXPECT_EQ(3U, v8HandleVector.size());
79 EXPECT_EQ("Vini, vidi, vici.", toUSVString(m_scope.isolate(), v8HandleVe ctor[0], exceptionState)); 79 EXPECT_EQ("Vini, vidi, vici.", toUSVString(m_scope.isolate(), v8HandleVe ctor[0], exceptionState));
80 EXPECT_EQ(65535U, toUInt32(m_scope.isolate(), v8HandleVector[1])); 80 EXPECT_EQ(65535U, toUInt32(m_scope.isolate(), v8HandleVector[1], NormalC onversion, exceptionState));
81 81
82 Vector<ScriptValue> scriptValueVector = toImplArray<ScriptValue>(v8Array , 0, m_scope.isolate(), exceptionState); 82 Vector<ScriptValue> scriptValueVector = toImplArray<ScriptValue>(v8Array , 0, m_scope.isolate(), exceptionState);
83 EXPECT_EQ(3U, scriptValueVector.size()); 83 EXPECT_EQ(3U, scriptValueVector.size());
84 String reportOnZela; 84 String reportOnZela;
85 EXPECT_TRUE(scriptValueVector[0].toString(reportOnZela)); 85 EXPECT_TRUE(scriptValueVector[0].toString(reportOnZela));
86 EXPECT_EQ("Vini, vidi, vici.", reportOnZela); 86 EXPECT_EQ("Vini, vidi, vici.", reportOnZela);
87 EXPECT_EQ(65535U, toUInt32(m_scope.isolate(), scriptValueVector[1].v8Val ue())); 87 EXPECT_EQ(65535U, toUInt32(m_scope.isolate(), scriptValueVector[1].v8Val ue(), NormalConversion, exceptionState));
88 } 88 }
89 { 89 {
90 v8::Handle<v8::Array> v8StringArray1 = v8::Array::New(m_scope.isolate(), 2); 90 v8::Handle<v8::Array> v8StringArray1 = v8::Array::New(m_scope.isolate(), 2);
91 v8StringArray1->Set(toV8(0), toV8("foo")); 91 v8StringArray1->Set(toV8(0), toV8("foo"));
92 v8StringArray1->Set(toV8(1), toV8("bar")); 92 v8StringArray1->Set(toV8(1), toV8("bar"));
93 v8::Handle<v8::Array> v8StringArray2 = v8::Array::New(m_scope.isolate(), 3); 93 v8::Handle<v8::Array> v8StringArray2 = v8::Array::New(m_scope.isolate(), 3);
94 v8StringArray2->Set(toV8(0), toV8("x")); 94 v8StringArray2->Set(toV8(0), toV8("x"));
95 v8StringArray2->Set(toV8(1), toV8("y")); 95 v8StringArray2->Set(toV8(1), toV8("y"));
96 v8StringArray2->Set(toV8(2), toV8("z")); 96 v8StringArray2->Set(toV8(2), toV8("z"));
97 v8::Handle<v8::Array> v8StringArrayArray = v8::Array::New(m_scope.isolat e(), 2); 97 v8::Handle<v8::Array> v8StringArrayArray = v8::Array::New(m_scope.isolat e(), 2);
98 v8StringArrayArray->Set(toV8(0), v8StringArray1); 98 v8StringArrayArray->Set(toV8(0), v8StringArray1);
99 v8StringArrayArray->Set(toV8(1), v8StringArray2); 99 v8StringArrayArray->Set(toV8(1), v8StringArray2);
100 100
101 NonThrowableExceptionState exceptionState; 101 NonThrowableExceptionState exceptionState;
102 Vector<Vector<String>> stringVectorVector = toImplArray<Vector<String>>( v8StringArrayArray, 0, m_scope.isolate(), exceptionState); 102 Vector<Vector<String>> stringVectorVector = toImplArray<Vector<String>>( v8StringArrayArray, 0, m_scope.isolate(), exceptionState);
103 EXPECT_EQ(2U, stringVectorVector.size()); 103 EXPECT_EQ(2U, stringVectorVector.size());
104 EXPECT_EQ(2U, stringVectorVector[0].size()); 104 EXPECT_EQ(2U, stringVectorVector[0].size());
105 EXPECT_EQ("foo", stringVectorVector[0][0]); 105 EXPECT_EQ("foo", stringVectorVector[0][0]);
106 EXPECT_EQ("bar", stringVectorVector[0][1]); 106 EXPECT_EQ("bar", stringVectorVector[0][1]);
107 EXPECT_EQ(3U, stringVectorVector[1].size()); 107 EXPECT_EQ(3U, stringVectorVector[1].size());
108 EXPECT_EQ("x", stringVectorVector[1][0]); 108 EXPECT_EQ("x", stringVectorVector[1][0]);
109 EXPECT_EQ("y", stringVectorVector[1][1]); 109 EXPECT_EQ("y", stringVectorVector[1][1]);
110 EXPECT_EQ("z", stringVectorVector[1][2]); 110 EXPECT_EQ("z", stringVectorVector[1][2]);
111 } 111 }
112 } 112 }
113 113
114 } // namespace 114 } // namespace
115 115
116 } // namespace blink 116 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/core/v8/custom/V8BlobCustomHelpers.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698