Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1011083003: Upgrade: Add 'Upgraded' header, update 'Prefer' value. (Closed)

Created:
5 years, 9 months ago by Mike West
Modified:
5 years, 9 months ago
Reviewers:
Yoav Weiss
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Upgrade: Add 'Upgraded' header, update 'Prefer' value. This patch updates our 'Upgrade Insecure Requests' implementation to match two spec changes: * [1] renamed the 'return=secure-representation' preference to 'tls' (after first renaming it to 'https' in [2]). * [3] added the 'Upgraded' request header to signal upgraded requests, detailed at [4]. [1]: https://github.com/w3c/webappsec/commit/29d07a99aebebd02f40a2daa9feb8425c36c5c21 [2]: https://github.com/w3c/webappsec/commit/a0aa404a84a0eca2040246fcd805980461d327ae [3]: https://github.com/w3c/webappsec/commit/05e5358eddcce3981a9f1afc5ff31bebc568cfb4 [4]: https://w3c.github.io/webappsec/specs/upgrade/#upgraded-header-field BUG=455674 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/core/loader/FrameFetchContext.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/loader/FrameFetchContextTest.cpp View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
Hey Yoav! Are you around today for a review? -mike
5 years, 9 months ago (2015-03-17 12:35:25 UTC) #2
Yoav Weiss
On 2015/03/17 12:35:25, Mike West wrote: > Hey Yoav! Are you around today for a ...
5 years, 9 months ago (2015-03-17 14:36:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011083003/1
5 years, 9 months ago (2015-03-18 08:52:10 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 09:14:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192074

Powered by Google App Engine
This is Rietveld 408576698