Issue 1011023003: Make stocks-fn match the style for the Sky SDK

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1011023003: Make stocks-fn match the style for the Sky SDK (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make stocks-fn match the style for the Sky SDK 1) Add a pubspec.yaml. 2) Move all the code into a 'lib' directory. 3) Move the stock widgets out of the app's library. TBR=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1aa4327112f60a3db268dd57a2376bc94f54e430

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -3379 lines)			Patch
D	sky/examples/data/stocks.dart	View	1	1 chunk	+0 lines, -3018 lines	0 comments	Download
A +	sky/examples/stocks-fn/lib/stock_app.dart	View	1	1 chunk	+5 lines, -10 lines	0 comments	Download
A +	sky/examples/stocks-fn/lib/stock_arrow.dart	View		5 chunks	+13 lines, -7 lines	0 comments	Download
A +	sky/examples/stocks-fn/lib/stock_data.dart	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sky/examples/stocks-fn/lib/stock_list.dart	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
A +	sky/examples/stocks-fn/lib/stock_row.dart	View	1	2 chunks	+15 lines, -8 lines	0 comments	Download
A +	sky/examples/stocks-fn/main.sky	View		1 chunk	+3 lines, -2 lines	0 comments	Download
A	sky/examples/stocks-fn/pubspec.yaml	View		1 chunk	+7 lines, -0 lines	0 comments	Download
D	sky/examples/stocks-fn/stockarrow.dart	View		1 chunk	+0 lines, -86 lines	0 comments	Download
D	sky/examples/stocks-fn/stocklist.dart	View		1 chunk	+0 lines, -22 lines	0 comments	Download
D	sky/examples/stocks-fn/stockrow.dart	View		1 chunk	+0 lines, -69 lines	0 comments	Download
D	sky/examples/stocks-fn/stocks.sky	View		1 chunk	+0 lines, -10 lines	0 comments	Download
D	sky/examples/stocks-fn/stocksapp.dart	View		1 chunk	+0 lines, -145 lines	0 comments	Download
M	sky/examples/stocks/stocks.sky	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/packages/sky/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-17 22:08:58 UTC) #2

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
1aa4327112f60a3db268dd57a2376bc94f54e430 (presubmit successful).