Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1775)

Issue 1011023002: Change for building font cache into separate thread inside utility process. (Closed)

Created:
5 years, 9 months ago by Shrikant Kelkar
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change for building font cache into separate thread inside utility process so that IO thread remains responsive. BUG=458751, 436195 R=cpu,scottmg Committed: https://crrev.com/e229ed0f0f2d4bab94fe4afb1213f7ddd6756d63 Cr-Commit-Position: refs/heads/master@{#320983}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reverted changes to chrome_browser_main_win (delay cache building.) #

Total comments: 2

Patch Set 3 : Changed thread name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M chrome/utility/font_cache_handler_win.h View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/utility/font_cache_handler_win.cc View 1 2 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Shrikant Kelkar
5 years, 9 months ago (2015-03-17 02:28:08 UTC) #1
scottmg
https://codereview.chromium.org/1011023002/diff/1/chrome/utility/font_cache_handler_win.cc File chrome/utility/font_cache_handler_win.cc (right): https://codereview.chromium.org/1011023002/diff/1/chrome/utility/font_cache_handler_win.cc#newcode26 chrome/utility/font_cache_handler_win.cc:26: utility_task_runner_ = base::MessageLoop::current()->message_loop_proxy(); This is in preparation for a ...
5 years, 9 months ago (2015-03-17 05:28:17 UTC) #2
Shrikant Kelkar
On 2015/03/17 05:28:17, scottmg wrote: > https://codereview.chromium.org/1011023002/diff/1/chrome/utility/font_cache_handler_win.cc > File chrome/utility/font_cache_handler_win.cc (right): > > https://codereview.chromium.org/1011023002/diff/1/chrome/utility/font_cache_handler_win.cc#newcode26 > ...
5 years, 9 months ago (2015-03-17 19:54:40 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/1011023002/diff/20001/chrome/utility/font_cache_handler_win.cc File chrome/utility/font_cache_handler_win.cc (right): https://codereview.chromium.org/1011023002/diff/20001/chrome/utility/font_cache_handler_win.cc#newcode29 chrome/utility/font_cache_handler_win.cc:29: cache_thread_.reset(new base::Thread("cache_thread")); use "font_cache_tread"
5 years, 9 months ago (2015-03-17 20:40:43 UTC) #4
Shrikant Kelkar
https://codereview.chromium.org/1011023002/diff/20001/chrome/utility/font_cache_handler_win.cc File chrome/utility/font_cache_handler_win.cc (right): https://codereview.chromium.org/1011023002/diff/20001/chrome/utility/font_cache_handler_win.cc#newcode29 chrome/utility/font_cache_handler_win.cc:29: cache_thread_.reset(new base::Thread("cache_thread")); On 2015/03/17 20:40:43, cpu wrote: > use ...
5 years, 9 months ago (2015-03-17 20:43:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011023002/40001
5 years, 9 months ago (2015-03-17 20:44:26 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-17 21:47:22 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 21:48:45 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e229ed0f0f2d4bab94fe4afb1213f7ddd6756d63
Cr-Commit-Position: refs/heads/master@{#320983}

Powered by Google App Engine
This is Rietveld 408576698