Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1011013002: Make GetAlternateProtocolRequestFor return AlternativeService. (Closed)

Created:
3 years, 7 months ago by Bence
Modified:
3 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make GetAlternateProtocolRequestFor return AlternativeService. Make HttpStreamFactoryImpl::GetAlternateProtocolRequestFor() return AlternativeService instead of AlternateProtocolInfo, and rename it to GetAlternativeServiceRequestFor. Also change the type and name of HttpStreamFactoryImplJob.{,other_job_}alternate_protocol_. BUG=392576 Committed: https://crrev.com/3ca96c302f4e02dada58b8c49bb491d1c4f235c5 Cr-Commit-Position: refs/heads/master@{#320925}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re: nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -30 lines) Patch
M net/http/http_stream_factory_impl.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 7 chunks +21 lines, -20 lines 0 comments Download
M net/http/http_stream_factory_impl_job.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_stream_factory_impl_job.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bence
Ryan, PTAL. Thanks.
3 years, 7 months ago (2015-03-17 11:41:04 UTC) #2
Ryan Hamilton
lgtm https://codereview.chromium.org/1011013002/diff/1/net/http/http_stream_factory_impl.cc File net/http/http_stream_factory_impl.cc (right): https://codereview.chromium.org/1011013002/diff/1/net/http/http_stream_factory_impl.cc#newcode108 net/http/http_stream_factory_impl.cc:108: GURL alternate_url; nit: At some point we really ...
3 years, 7 months ago (2015-03-17 13:53:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1011013002/20001
3 years, 7 months ago (2015-03-17 14:40:48 UTC) #6
Bence
Ryan: thank you. https://codereview.chromium.org/1011013002/diff/1/net/http/http_stream_factory_impl.cc File net/http/http_stream_factory_impl.cc (right): https://codereview.chromium.org/1011013002/diff/1/net/http/http_stream_factory_impl.cc#newcode108 net/http/http_stream_factory_impl.cc:108: GURL alternate_url; On 2015/03/17 13:53:09, Ryan ...
3 years, 7 months ago (2015-03-17 14:40:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
3 years, 7 months ago (2015-03-17 16:02:27 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2015-03-17 16:03:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ca96c302f4e02dada58b8c49bb491d1c4f235c5
Cr-Commit-Position: refs/heads/master@{#320925}

Powered by Google App Engine
This is Rietveld 408576698