chrome/browser/extensions/external_component_loader.cc - Issue 1010973013: Refactor Uses of std::set to std::vector in SimpleFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_component_loader.cc

Issue 1010973013: Refactor Uses of std::set to std::vector in SimpleFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsIdInArray and other Cleanup Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/stl_util.h ('K') | « chrome/browser/extensions/api/tab_capture/tab_capture_api.cc ('k') | extensions/browser/api/app_window/app_window_api.cc » ('j') | extensions/common/features/simple_feature.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_component_loader.cc

diff --git a/chrome/browser/extensions/external_component_loader.cc b/chrome/browser/extensions/external_component_loader.cc

index e242332cf3d5075b06c16b8911b7e6b78b3e4f6e..b9c9d2b2002e0ab2fbc5c45aa2ea8d76d064aa45 100644

--- a/chrome/browser/extensions/external_component_loader.cc

+++ b/chrome/browser/extensions/external_component_loader.cc

@@ -41,11 +41,8 @@ bool ExternalComponentLoader::IsModifiable(const Extension* extension) {

"D57DE394F36DC1C3220E7604C575D29C51A6C495", // http://crbug.com/319444

"3F65507A3B39259B38C8173C6FFA3D12DF64CCE9" // http://crbug.com/371562

};

- return SimpleFeature::IsIdInList(

- extension->id(),

- std::set<std::string>(

- kEnhancedExtensions,

- kEnhancedExtensions + arraysize(kEnhancedExtensions)));

+ return SimpleFeature::IsIdInArray(

+ extension->id(), kEnhancedExtensions, arraysize(kEnhancedExtensions));

}

return false;

}