chrome/browser/content_settings/content_settings_internal_extension_provider.cc - Issue 1010973013: Refactor Uses of std::set to std::vector in SimpleFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_internal_extension_provider.cc

Issue 1010973013: Refactor Uses of std::set to std::vector in SimpleFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: IsIdInArray and other Cleanup Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/content_settings/content_settings_internal_extension_provider.cc

diff --git a/chrome/browser/content_settings/content_settings_internal_extension_provider.cc b/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

index d6be8d60695284b0b71d47d4364088595c1340c9..ae8161d7cc7b99bc5bfc9647d2218ec095592736 100644

--- a/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

+++ b/chrome/browser/content_settings/content_settings_internal_extension_provider.cc

@@ -138,10 +138,10 @@ void InternalExtensionProvider::Observe(

"48CA541313139786F056DBCB504A1025CFF5D2E3",

"05106136AE7F08A3C181D4648E5438350B1D2B4F"

};

- if (extensions::SimpleFeature::IsIdInList(

+ if (extensions::SimpleFeature::IsIdInArray(

host->extension()->id(),

- std::set<std::string>(

- kAppWhitelist, kAppWhitelist + arraysize(kAppWhitelist)))) {

+ kAppWhitelist,

+ arraysize(kAppWhitelist))) {

SetContentSettingForExtensionAndResource(

host->extension(),

ChromeContentClient::kRemotingViewerPluginPath,

« base/stl_util.h ('K') | « base/stl_util.h ('k') | chrome/browser/extensions/api/tab_capture/tab_capture_api.cc » ('j') | extensions/common/features/simple_feature.h » ('J')