Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: extensions/browser/api/app_window/app_window_api.cc

Issue 1010973013: Refactor Uses of std::set to std::vector in SimpleFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove Unsigned From Checks with STLCount Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/app_window/app_window_api.cc
diff --git a/extensions/browser/api/app_window/app_window_api.cc b/extensions/browser/api/app_window/app_window_api.cc
index 3f5123ff9d5491fb97dc09199485deeeca98a103..089f0fc76d98a4de9a72826bd6804866e5c779fd 100644
--- a/extensions/browser/api/app_window/app_window_api.cc
+++ b/extensions/browser/api/app_window/app_window_api.cc
@@ -263,10 +263,8 @@ bool AppWindowCreateFunction::RunAsync() {
"0F585FB1D0FDFBEBCE1FEB5E9DFFB6DA476B8C9B"
};
if (AppWindowClient::Get()->IsCurrentChannelOlderThanDev() &&
- !SimpleFeature::IsIdInList(
- extension_id(),
- std::set<std::string>(kWhitelist,
- kWhitelist + arraysize(kWhitelist)))) {
+ !SimpleFeature::IsIdInArray(
+ extension_id(), kWhitelist, arraysize(kWhitelist))) {
error_ = app_window_constants::kAlphaEnabledWrongChannel;
return false;
}

Powered by Google App Engine
This is Rietveld 408576698