chrome/browser/extensions/api/tab_capture/tab_capture_api.cc - Issue 1010973013: Refactor Uses of std::set to std::vector in SimpleFeature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

Issue 1010973013: Refactor Uses of std::set to std::vector in SimpleFeature (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove Unsigned From Checks with STLCount Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/stl_util.h ('K') | « chrome/browser/content_settings/content_settings_internal_extension_provider.cc ('k') | chrome/browser/extensions/external_component_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

diff --git a/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc b/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

index 514cb02523f0b67c7e08c257a3d38580aee0f4ad..df6b5ff5b805fcf062f81452ee61c306e2e5b0b2 100644

--- a/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

+++ b/chrome/browser/extensions/api/tab_capture/tab_capture_api.cc

@@ -91,10 +91,8 @@ bool TabCaptureCaptureFunction::RunSync() {

APIPermission::kTabCaptureForTab) &&

base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(

switches::kWhitelistedExtensionID) != extension_id &&

- !SimpleFeature::IsIdInList(

- extension_id,

- std::set<std::string>(kWhitelist,

- kWhitelist + arraysize(kWhitelist)))) {

+ !SimpleFeature::IsIdInArray(

+ extension_id, kWhitelist, arraysize(kWhitelist))) {

error_ = kGrantError;

return false;

}