Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1010973010: Added %_HeapObjectGetMap and %_MapGetInstanceType intrinsics. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Added %_HeapObjectGetMap and %_MapGetInstanceType intrinsics. These are needed (among other things) for a TurboFan-generated StringAddStub. Furthermore, they can be used to nuke the overly complex %_IsInstanceType intrisic, it's completely expressible in JavaScript now, but that will be done in a separate CL. Alpha-sorted things a bit on the way to ease navigation. Committed: https://crrev.com/20dce719eeb4a066d067d5aac7f849ce8a3271ac Cr-Commit-Position: refs/heads/master@{#27415}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Renamed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -155 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 1 chunk +15 lines, -13 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 6 chunks +81 lines, -57 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-intrinsics.cc View 8 chunks +111 lines, -84 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sven Panne
5 years, 9 months ago (2015-03-24 13:45:46 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1010973010/diff/1/src/compiler/js-intrinsic-lowering.h File src/compiler/js-intrinsic-lowering.h (right): https://codereview.chromium.org/1010973010/diff/1/src/compiler/js-intrinsic-lowering.h#newcode30 src/compiler/js-intrinsic-lowering.h:30: Reduction ReduceInlineConstructDouble(Node* node); I never understood the "Inline" ...
5 years, 9 months ago (2015-03-24 13:57:57 UTC) #3
Sven Panne
On 2015/03/24 13:57:57, Michael Starzinger wrote: > I never understood the "Inline" prefix in all ...
5 years, 9 months ago (2015-03-24 14:58:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010973010/20001
5 years, 9 months ago (2015-03-24 14:59:09 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-24 15:20:50 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 15:21:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/20dce719eeb4a066d067d5aac7f849ce8a3271ac
Cr-Commit-Position: refs/heads/master@{#27415}

Powered by Google App Engine
This is Rietveld 408576698