Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Issue 1010913002: Rename Sky's Toolbar to ActionBar (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename Sky's Toolbar to ActionBar This naming matches the naming in Material Design. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4a84f10d55ca3ad02c242b49a7cee88e6f460d10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -35 lines) Patch
M sky/examples/stocks-fn/stocksapp.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A + sky/framework/components/action_bar.dart View 2 chunks +2 lines, -2 lines 0 comments Download
D sky/framework/components/toolbar.dart View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-16 20:23:26 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-16 20:24:30 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-16 20:26:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4a84f10d55ca3ad02c242b49a7cee88e6f460d10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698