Source/core/frame/csp/ContentSecurityPolicy.cpp - Issue 1010893003: Upgrade insecure requests: Pipe navigational hosts down into nested documents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/csp/ContentSecurityPolicy.cpp

Issue 1010893003: Upgrade insecure requests: Pipe navigational hosts down into nested documents. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/csp/ContentSecurityPolicy.cpp

diff --git a/Source/core/frame/csp/ContentSecurityPolicy.cpp b/Source/core/frame/csp/ContentSecurityPolicy.cpp

index 7533db5ee3cc34b2a34e511ebb043f580591ec65..c7d5031576a4841bb791521e945cc85eb21c1a1d 100644

--- a/Source/core/frame/csp/ContentSecurityPolicy.cpp

+++ b/Source/core/frame/csp/ContentSecurityPolicy.cpp

@@ -176,8 +176,10 @@ void ContentSecurityPolicy::applyPolicySideEffectsToExecutionContext()

document->enforceStrictMixedContentChecking();

if (didSetReferrerPolicy())

document->setReferrerPolicy(m_referrerPolicy);

- if (m_insecureRequestsPolicy > document->insecureRequestsPolicy())

+ if (m_insecureRequestsPolicy > document->insecureRequestsPolicy()) {

document->setInsecureRequestsPolicy(m_insecureRequestsPolicy);

+ document->addInsecureNavigationUpgrade(securityOrigin()->host().impl()->hash());

+ }

Yoav Weiss 2015/03/17 15:17:27 Are we sure that securityOrigin is not null? Same

Mike West 2015/03/18 09:31:53 ASSERT and isNull() added.

for (const auto& consoleMessage : m_consoleMessages)

m_executionContext->addConsoleMessage(consoleMessage);

« no previous file with comments | « Source/core/dom/SecurityContext.h ('k') | Source/core/frame/csp/ContentSecurityPolicyTest.cpp » ('j') | Source/core/loader/FrameLoader.cpp » ('J')