Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 1010893002: test-only change - Squelch a variety of "GMOCK WARNING" messages in (Closed)

Created:
5 years, 9 months ago by ramant (doing other things)
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Final_0315_2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

test-only change - Squelch a variety of "GMOCK WARNING" messages in quic_session_test by using a StrictMock, and adding the necessary EXPECT_CALL()s. Merge internal change: 83469149 R=rch@chromium.org Committed: https://crrev.com/9eb6253e8abd21bf4f11b8ff4ffa9fa03df3301d Cr-Commit-Position: refs/heads/master@{#320869}

Patch Set 1 #

Patch Set 2 : Backed out change to quic_unacked_packet_map_test.cc to fix compiler error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M net/quic/quic_session_test.cc View 14 chunks +20 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
ramant (doing other things)
5 years, 9 months ago (2015-03-16 20:07:24 UTC) #1
ramant (doing other things)
On 2015/03/16 20:07:24, ramant wrote: Hi Ryan, While merging chromium changes back into internal source ...
5 years, 9 months ago (2015-03-16 20:10:55 UTC) #2
Ryan Hamilton
lgtm
5 years, 9 months ago (2015-03-17 03:06:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010893002/1
5 years, 9 months ago (2015-03-17 03:28:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/38384)
5 years, 9 months ago (2015-03-17 04:46:14 UTC) #7
ramant (doing other things)
On 2015/03/17 04:46:14, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-17 04:54:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010893002/20001
5 years, 9 months ago (2015-03-17 04:54:20 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 05:32:53 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 05:33:27 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9eb6253e8abd21bf4f11b8ff4ffa9fa03df3301d
Cr-Commit-Position: refs/heads/master@{#320869}

Powered by Google App Engine
This is Rietveld 408576698