Reset the background of title label when selected by arrow keys.

Reset the background of title label when selected by arrow keys.

In the old app-list, the key selection doesn't signal any events
to AppListItemView, so it can't update the background color at
that point.

BUG=467517
R=mgiuca@chromium.org

Committed: https://crrev.com/2b7b3c8c3a6d31a2d308063f73ba5e0e6cf6ea15
Cr-Commit-Position: refs/heads/master@{#320800}

[Matt Giuca, 2015-03-16 18:22:59]

lgtm

https://codereview.chromium.org/1010853002/diff/1/ui/app_list/views/app_list_...
File ui/app_list/views/app_list_item_view.h (right):

https://codereview.chromium.org/1010853002/diff/1/ui/app_list/views/app_list_...
ui/app_list/views/app_list_item_view.h:86: void SetTitleSubpixelAA();
Please move the implementation of this method up to after
GetIconBoundsForTargetViewBounds in the .cc file, so we keep the two files in a
consistent order.

[Jun Mukai, 2015-03-16 20:49:55]

https://codereview.chromium.org/1010853002/diff/1/ui/app_list/views/app_list_...
File ui/app_list/views/app_list_item_view.h (right):

https://codereview.chromium.org/1010853002/diff/1/ui/app_list/views/app_list_...
ui/app_list/views/app_list_item_view.h:86: void SetTitleSubpixelAA();
On 2015/03/16 18:22:59, Matt Giuca wrote:
> Please move the implementation of this method up to after
> GetIconBoundsForTargetViewBounds in the .cc file, so we keep the two files in
a
> consistent order.

Done.

[Jun Mukai, 2015-03-16 20:49:58]

The CQ bit was checked by mukai@chromium.org

[Jun Mukai, 2015-03-16 20:49:59]

The patchset sent to the CQ was uploaded after l-g-t-m from mgiuca@chromium.org
Link to the patchset: https://codereview.chromium.org/1010853002/#ps20001
(title: "commends addressed")

[commit-bot: I haz the power, 2015-03-16 20:50:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010853002/20001

[commit-bot: I haz the power, 2015-03-16 22:00:02]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-16 22:01:13]

Patchset 2 (id:??) landed as
https://crrev.com/2b7b3c8c3a6d31a2d308063f73ba5e0e6cf6ea15
Cr-Commit-Position: refs/heads/master@{#320800}

[tapted, 2015-03-17 03:28:31]

tapted@chromium.org changed reviewers:
+ tapted@chromium.org

[tapted, 2015-03-17 03:28:31]

drive-by (no action required :)

https://codereview.chromium.org/1010853002/diff/20001/ui/app_list/views/apps_...
File ui/app_list/views/apps_grid_view.cc (right):

https://codereview.chromium.org/1010853002/diff/20001/ui/app_list/views/apps_...
ui/app_list/views/apps_grid_view.cc:1109: selected_view_->SchedulePaint();
I suspect the old selected view also needs an update, but probably after
updating the selection (i.e. not in this `if` block, but down below). But it's
minor - you will just miss out on some subpixel AA if you use arrow keys, which
should be fine -- I wouldn't do anything.

The app list font on Windows is changing in M42. I think it doesn't look as bad
without subpixel AA, so it might be time just to give up on subpixel AA.

Although, I will definitely need to fix http://crbug.com/462136 for Mac first --
there's a bug causing a "don't do subpixel AA" failing to get through to skia.