Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1010833003: Pull our new test case repository via deps. (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, jam
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pull our new test case repository via deps. Add a run_corpus_tests.py script to run pdfium_test against the corpus tree. Note that this differs from the run_pixel_tests.py script, since pre-processing is not required. I'll work on unifying these in a subsequent CL. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b29e12ac58aea7ca43d726e152770e7ea80ab54a

Patch Set 1 #

Patch Set 2 : Call it "corpus" #

Patch Set 3 : Add test runner script. #

Patch Set 4 : Fix typo in .py file name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -21 lines) Patch
M DEPS View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + testing/tools/run_corpus_tests.py View 1 2 3 3 chunks +16 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
John, please review. As far as naming is concerned, having pdfium pdfium_tests as the names ...
5 years, 9 months ago (2015-03-16 18:47:58 UTC) #2
Tom Sepez
On 2015/03/16 18:47:58, Tom Sepez wrote: > hence the testcases path. s/testcases/corpus/. The collected pdfs ...
5 years, 9 months ago (2015-03-16 21:09:28 UTC) #3
Tom Sepez
+thestig@
5 years, 9 months ago (2015-03-16 22:02:33 UTC) #5
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-16 22:20:37 UTC) #6
Tom Sepez
5 years, 9 months ago (2015-03-16 22:22:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b29e12ac58aea7ca43d726e152770e7ea80ab54a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698