Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 101083002: Revert "Introduce MoveDouble to the X64 MacroAssembler" (r17383) (Closed)

Created:
7 years ago by haitao.feng
Modified:
6 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Revert "Introduce MoveDouble to the X64 MacroAssembler" (r17383) The direction is to use "movl, movq, movp" instead of introducing new Macro assembler instructions. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19210

Patch Set 1 #

Patch Set 2 : Rebased with bleeding_edge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M src/x64/codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
PTAL. Thanks.
7 years ago (2013-12-03 05:46:14 UTC) #1
Toon Verwaest
lgtm
7 years ago (2013-12-04 09:45:55 UTC) #2
haitao.feng
6 years, 10 months ago (2014-02-08 02:16:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19210 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698