Fixing building of remoting_unittests_apk target.

remoting/remoting_test.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'targets': [
     {
       # GN version: //remoting:test_support
       'target_name': 'remoting_test_common',
       'type': 'static_library',
@@ skipping 228 matching lines @@
         'protocol/message_reader_unittest.cc',
         'protocol/monitored_video_stub_unittest.cc',
         'protocol/mouse_input_filter_unittest.cc',
         'protocol/negotiating_authenticator_unittest.cc',
         'protocol/pairing_registry_unittest.cc',
         'protocol/port_range_unittest.cc',
         'protocol/ppapi_module_stub.cc',
         'protocol/ssl_hmac_channel_authenticator_unittest.cc',
         'protocol/third_party_authenticator_unittest.cc',
         'protocol/v2_authenticator_unittest.cc',
-        'signaling/fake_signal_strategy.cc',

[Łukasz Anforowicz, 2015/03/23 23:57:11]

The removed source files are also present in remoting_test_common target. 
Without removing these files, linking would fail with multiple cases of:

/usr/local/google/home/lukasza/src/chromium/src/third_party/android_tools/ndk/toolchains/x86-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/i686-linux-android/4.9/../../../../i686-linux-android/bin/ld.gold:
error:
obj/remoting/libremoting_test_common.a(obj/remoting/signaling/remoting_test_common.fake_signal_strategy.o):
multiple definition of 'remoting::FakeSignalStrategy::GetState() const'
/usr/local/google/home/lukasza/src/chromium/src/third_party/android_tools/ndk/toolchains/x86-4.9/prebuilt/linux-x86_64/bin/../lib/gcc/i686-linux-android/4.9/../../../../i686-linux-android/bin/ld.gold:
obj/remoting/signaling/remoting_unittests.fake_signal_strategy.o: previous
definition here

Interestingly, there are other source files that appears both in
remoting_test_common and in remoting_unittests targets (i.e.
host/fake_resktop_capturer.cc).  FWIW, these do not cause a linking error on
Android, so for now I am making a minimal change to enable building (and later)
running remoting_unittests on Android.

-        'signaling/fake_signal_strategy.h',
         'signaling/iq_sender_unittest.cc',
         'signaling/log_to_server_unittest.cc',
         'signaling/server_log_entry_unittest.cc',
         'signaling/server_log_entry_unittest.h',
         'signaling/xmpp_login_handler_unittest.cc',
         'signaling/xmpp_stream_parser_unittest.cc',
         'signaling/xmpp_signal_strategy_unittest.cc',
         'test/access_token_fetcher_unittest.cc',
         'test/app_remoting_test_driver_environment_unittest.cc',
         'test/remote_host_info_fetcher_unittest.cc',
@@ skipping 11 matching lines @@
             'libraries': [
               '-lrpcrt4.lib',
               '-lwtsapi32.lib',
             ],
           },
         }],
         [ 'OS=="android"', {
           'dependencies!': [
             'remoting_client_plugin',
           ],
+          'sources!': [

[Lambros, 2015/03/24 00:19:20]

I think you should remove everything from plugin/ directory like this:

  'sources/': [
    ['exclude', '^client/plugin/'],
  ]

(See line 87 above, where we do something similar for host/ stuff)

[Łukasz Anforowicz, 2015/03/24 17:10:23]

Good point.  Done.

+            'client/plugin/empty_cursor_filter_unittest.cc',
+            'client/plugin/normalizing_input_filter_cros_unittest.cc',
+            'client/plugin/normalizing_input_filter_mac_unittest.cc',
+            'client/plugin/touch_input_scaler_unittest.cc',

[Łukasz Anforowicz, 2015/03/23 23:57:11]

Since we are removing remoting_client_plugin when building for Android, we also
need to remove tests that depend on remoting_client_plugin.

Example linking error when linking object files created from the test sources
being removed:
../../remoting/client/plugin/empty_cursor_filter_unittest.cc:69: error:
undefined reference to 'remoting::EmptyCursorShape()'

+          ],
         }],
         [ 'OS=="android"', {
           'dependencies': [
             '../testing/android/native_test.gyp:native_test_native_code',
           ],
         }],
         [ 'chromeos==0', {
           'sources!': [
             'client/plugin/normalizing_input_filter_cros_unittest.cc',
             'host/chromeos/aura_desktop_capturer_unittest.cc',
@@ skipping 159 matching lines @@
               'dependencies': [
                 '../base/allocator/allocator.gyp:allocator',
               ],
             }],
           ],  # end of 'conditions'
         },  # end of target 'remoting_perftests'
       ]
     }]
   ]
 }