Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1010803013: Revert of De-dupe copy requests for tab capture in DelegatedFrameHost. (Closed)

Created:
5 years, 9 months ago by miu
Modified:
5 years, 9 months ago
Reviewers:
danakj, hubbe, ccameron
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of De-dupe copy requests for tab capture in DelegatedFrameHost. (patchset #7 id:160001 of https://codereview.chromium.org/986823002/) Reason for revert: Weird frame flickering effect in capture on some systems. https://crbug.com/469345 Original issue's description: > De-dupe copy requests for tab capture in DelegatedFrameHost. > > Tab capture requests copies/readbacks in response to every delegated > frame swap from the renderer. These are executed in a later step, when > the browser is composited. Unfortunately, the browser may not be > composited for every render frame. This means multiple copies/readbacks > may become enqueued, each of which is expensive, and will turn out to be > completely redundant as the results will be identical. This change > detects this scenario, and de-dupes by "aborting" the older frame > subscriber callback. > > BUG=464475 > > Committed: https://crrev.com/ddee0845cc298cbba6f9d8d6ff7fb9e06073f0e8 > Cr-Commit-Position: refs/heads/master@{#319998} TBR=danakj@chromium.org,ccameron@chromium.org,hubbe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464475 Committed: https://crrev.com/ca0aa371d85941c6ea66b325efa237b339e23319 Cr-Commit-Position: refs/heads/master@{#321828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -216 lines) Patch
M content/browser/compositor/delegated_frame_host.h View 3 chunks +0 lines, -19 lines 0 comments Download
M content/browser/compositor/delegated_frame_host.cc View 4 chunks +7 lines, -39 lines 0 comments Download
M content/browser/media/capture/video_capture_oracle.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 5 chunks +17 lines, -153 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
miu
Created Revert of De-dupe copy requests for tab capture in DelegatedFrameHost.
5 years, 9 months ago (2015-03-23 19:25:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010803013/1
5 years, 9 months ago (2015-03-23 19:26:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 19:27:19 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 19:28:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca0aa371d85941c6ea66b325efa237b339e23319
Cr-Commit-Position: refs/heads/master@{#321828}

Powered by Google App Engine
This is Rietveld 408576698