Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1010803012: Merge cellspace into old pointer space (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Merge cellspace into old pointer space BUG= Committed: https://crrev.com/4e7163ce05f135918205c7855ae60a48e5d46cc5 Cr-Commit-Position: refs/heads/master@{#27707}

Patch Set 1 : Add writebarrier to the instanceof stub #

Patch Set 2 : #

Patch Set 3 : Don't clobber x8 #

Patch Set 4 : Don't clobber x10 either... #

Patch Set 5 : #

Patch Set 6 : Rebase #

Patch Set 7 : Including mips changes #

Total comments: 3

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -223 lines) Patch
M include/v8.h View 1 2 3 4 5 2 chunks +2 lines, -3 lines 0 comments Download
M src/api.cc View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 1 chunk +7 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/assembler.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/counters.h View 1 2 3 4 5 3 chunks +0 lines, -8 lines 0 comments Download
M src/extensions/statistics-extension.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M src/globals.h View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 4 chunks +12 lines, -18 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 23 chunks +7 lines, -65 lines 0 comments Download
M src/heap/heap-inl.h View 1 2 3 4 5 2 chunks +0 lines, -3 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 4 5 3 chunks +0 lines, -6 lines 0 comments Download
M src/heap/mark-compact.h View 1 2 3 4 5 2 chunks +3 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 5 16 chunks +18 lines, -47 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/heap/spaces.h View 1 2 3 4 5 1 chunk +0 lines, -25 lines 0 comments Download
M src/heap/spaces.cc View 1 2 3 4 5 3 chunks +0 lines, -12 lines 0 comments Download
M src/heap/store-buffer.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/store-buffer-inl.h View 1 2 3 4 5 2 chunks +1 line, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M src/ia32/assembler-ia32-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 3 chunks +1 line, -2 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 1 chunk +1 line, -11 lines 0 comments Download
M src/snapshot/serialize.h View 1 2 3 4 5 6 7 1 chunk +8 lines, -4 lines 0 comments Download
M src/snapshot/serialize.cc View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
Toon Verwaest
PTAL balazs.kilvady: fyi
5 years, 9 months ago (2015-03-26 17:33:40 UTC) #4
balazs.kilvady
On 2015/03/26 17:33:40, Toon Verwaest wrote: > PTAL > balazs.kilvady: fyi Thank you for the ...
5 years, 9 months ago (2015-03-26 19:12:25 UTC) #5
balazs.kilvady
On 2015/03/26 17:33:40, Toon Verwaest wrote: > PTAL > balazs.kilvady: fyi I've ported your CL ...
5 years, 9 months ago (2015-03-27 17:26:28 UTC) #6
Toon Verwaest
Addressed ishell's comment
5 years, 8 months ago (2015-03-31 15:16:51 UTC) #7
Hannes Payer (out of office)
LGTM. watch out, there will be a merge conflict with the old space merging.
5 years, 8 months ago (2015-04-08 07:38:44 UTC) #8
Yang
On 2015/04/08 07:38:44, Hannes Payer wrote: > LGTM. watch out, there will be a merge ...
5 years, 8 months ago (2015-04-08 09:09:10 UTC) #9
Yang
https://codereview.chromium.org/1010803012/diff/160001/src/snapshot/serialize.h File src/snapshot/serialize.h (right): https://codereview.chromium.org/1010803012/diff/160001/src/snapshot/serialize.h#newcode313 src/snapshot/serialize.h:313: // 0x00..0x03 Allocate new object, in specified space. That's ...
5 years, 8 months ago (2015-04-08 09:11:53 UTC) #11
Yang
On 2015/04/08 09:11:53, Yang wrote: > https://codereview.chromium.org/1010803012/diff/160001/src/snapshot/serialize.h > File src/snapshot/serialize.h (right): > > https://codereview.chromium.org/1010803012/diff/160001/src/snapshot/serialize.h#newcode313 > ...
5 years, 8 months ago (2015-04-08 09:26:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010803012/180001
5 years, 8 months ago (2015-04-08 14:56:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010803012/180001
5 years, 8 months ago (2015-04-09 13:16:29 UTC) #18
commit-bot: I haz the power
Committed patchset #8 (id:180001)
5 years, 8 months ago (2015-04-09 13:34:24 UTC) #19
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/4e7163ce05f135918205c7855ae60a48e5d46cc5 Cr-Commit-Position: refs/heads/master@{#27707}
5 years, 8 months ago (2015-04-09 13:34:34 UTC) #20
adamk
A revert of this CL (patchset #8 id:180001) has been created in https://codereview.chromium.org/1053243003/ by adamk@chromium.org. ...
5 years, 8 months ago (2015-04-09 18:15:50 UTC) #21
vogelheim
5 years, 8 months ago (2015-04-09 18:16:03 UTC) #22
Message was sent while issue was closed. 
A revert of this CL (patchset #8 id:180001) has been created in
https://codereview.chromium.org/1071253002/ by vogelheim@chromium.org.

The reason for reverting is: Numerous tests on ARM are broken and manual bisect
points to this CL.
.

Powered by Google App Engine
This is Rietveld 408576698