[Telemetry] Update page_set_smoke_test to check for mix states in page set.

[Telemetry] Update page_set_smoke_test to check for mix states in page set.

BUG=468085
Committed: https://crrev.com/3fcda3af7062ff8681f0ec096b896ba862495944
Cr-Commit-Position: refs/heads/master@{#321197}

[nednguyen, 2015-03-17 22:57:59]

nednguyen@google.com changed reviewers:
+ aiolos@chromium.org, sullivan@chromium.org

[aiolos (Not reviewing), 2015-03-17 23:09:40]

https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py (left):

https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:64: def
CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions(
This should be in a separate CL.

https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py (right):

https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:115: def
CheckSharedStates(self, page_set):
Should this be changed to story_set or user_story_set since we're getting rid of
page_sets shortly?

[aiolos (Not reviewing), 2015-03-17 23:10:13]

Also, good call for adding that test to the smoke tests.

[nednguyen, 2015-03-17 23:11:51]

On 2015/03/17 23:09:40, aiolos wrote:
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py (left):
> 
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:64: def
> CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions(
> This should be in a separate CL.
> 
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py (right):
> 
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:115: def
> CheckSharedStates(self, page_set):
> Should this be changed to story_set or user_story_set since we're getting rid
of
> page_sets shortly?

Yeah, but let's do it in a different patch though.

[aiolos (Not reviewing), 2015-03-17 23:17:23]

On 2015/03/17 23:11:51, nednguyen wrote:
> On 2015/03/17 23:09:40, aiolos wrote:
> >
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> > File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py (left):
> > 
> >
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> > tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:64: def
> > CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions(
> > This should be in a separate CL.
> > 
> >
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> > File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py (right):
> > 
> >
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> > tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:115: def
> > CheckSharedStates(self, page_set):
> > Should this be changed to story_set or user_story_set since we're getting
rid
> of
> > page_sets shortly?
> 
> Yeah, but let's do it in a different patch though.

sgtm

[nednguyen, 2015-03-18 15:05:18]

On 2015/03/17 23:17:23, aiolos wrote:
> On 2015/03/17 23:11:51, nednguyen wrote:
> > On 2015/03/17 23:09:40, aiolos wrote:
> > >
> >
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> > > File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
(left):
> > > 
> > >
> >
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> > > tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:64: def
> > > CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions(
> > > This should be in a separate CL.
> > > 
> > >
> >
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> > > File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py
(right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
> > > tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:115: def
> > > CheckSharedStates(self, page_set):
> > > Should this be changed to story_set or user_story_set since we're getting
> rid
> > of
> > > page_sets shortly?
> > 
> > Yeah, but let's do it in a different patch though.
> 
> sgtm

PTAL

[nednguyen, 2015-03-18 15:12:40]

https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
File tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py (left):

https://codereview.chromium.org/1010773008/diff/1/tools/telemetry/telemetry/u...
tools/telemetry/telemetry/unittest_util/page_set_smoke_test.py:64: def
CheckNoMixedInBetweenLegacyRunMethodsAndRunPageInteractions(
On 2015/03/17 23:09:40, aiolos wrote:
> This should be in a separate CL.

Done.

[aiolos (Not reviewing), 2015-03-18 17:06:14]

lgtm

[nednguyen, 2015-03-18 17:11:35]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2015-03-18 17:11:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010773008/20001

[commit-bot: I haz the power, 2015-03-18 17:36:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-18 17:36:20]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[nednguyen, 2015-03-18 18:05:08]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-03-18 18:05:15]

The CQ bit was unchecked by nednguyen@google.com

[nednguyen, 2015-03-18 18:08:14]

The CQ bit was checked by nednguyen@google.com

[nednguyen, 2015-03-18 18:08:15]

The patchset sent to the CQ was uploaded after l-g-t-m from aiolos@chromium.org
Link to the patchset: https://codereview.chromium.org/1010773008/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-18 18:08:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1010773008/40001

[commit-bot: I haz the power, 2015-03-18 20:04:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-18 20:05:58]

Patchset 3 (id:??) landed as
https://crrev.com/3fcda3af7062ff8681f0ec096b896ba862495944
Cr-Commit-Position: refs/heads/master@{#321197}