Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 1010743007: Autofill: Apply the same field match mask to all phone field subtypes. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Apply the same field match mask to all phone field subtypes. - Modify unit tests to test relevant field types. - Cleanup code. - Update heuristics test expectations. Committed: https://crrev.com/70c9d025b846e35d60d6581e9b2a39428796535b Cr-Commit-Position: refs/heads/master@{#322312}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+219 lines, -187 lines) Patch
M chrome/test/data/autofill/heuristics/output/24_checkout_harryanddavid.com.out View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/phone_field.h View 1 chunk +7 lines, -2 lines 0 comments Download
M components/autofill/core/browser/phone_field.cc View 8 chunks +50 lines, -40 lines 0 comments Download
M components/autofill/core/browser/phone_field_unittest.cc View 4 chunks +161 lines, -144 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
Lei Zhang
https://codereview.chromium.org/1010743007/diff/40001/components/autofill/core/browser/phone_field_unittest.cc File components/autofill/core/browser/phone_field_unittest.cc (right): https://codereview.chromium.org/1010743007/diff/40001/components/autofill/core/browser/phone_field_unittest.cc#newcode22 components/autofill/core/browser/phone_field_unittest.cc:22: "tel", FYI, I intend to add "number" in a ...
5 years, 9 months ago (2015-03-26 02:09:16 UTC) #3
Evan Stade
I cannot parse this sentence: "Make PhoneField parse fields with the same match type."
5 years, 9 months ago (2015-03-26 02:13:13 UTC) #5
Lei Zhang
On 2015/03/26 02:13:13, Evan Stade wrote: > I cannot parse this sentence: "Make PhoneField parse ...
5 years, 9 months ago (2015-03-26 02:14:54 UTC) #6
Evan Stade
On 2015/03/26 02:14:54, Lei Zhang wrote: > On 2015/03/26 02:13:13, Evan Stade wrote: > > ...
5 years, 9 months ago (2015-03-26 02:30:45 UTC) #7
Evan Stade
now that i understand that, lgtm
5 years, 9 months ago (2015-03-26 02:32:01 UTC) #8
Lei Zhang
On 2015/03/26 02:30:45, Evan Stade wrote: > Apply same field match mask to all phone ...
5 years, 9 months ago (2015-03-26 02:32:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010743007/40001
5 years, 9 months ago (2015-03-26 02:33:47 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 9 months ago (2015-03-26 03:54:15 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 03:55:04 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70c9d025b846e35d60d6581e9b2a39428796535b
Cr-Commit-Position: refs/heads/master@{#322312}

Powered by Google App Engine
This is Rietveld 408576698