Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1010683003: Fix a stray reference to 'build_os' in BUILD.gn. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix a stray reference to 'build_os' in BUILD.gn. This should be 'host_os'; the build_os variable is going away. R=jochen@chromium.org BUG=344767 LOG=n Committed: https://crrev.com/8213be1a06f364feb2930bb33e530d007477f509 Cr-Commit-Position: refs/heads/master@{#27302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Dirk Pranke
5 years, 9 months ago (2015-03-19 04:36:00 UTC) #1
Dirk Pranke
5 years, 9 months ago (2015-03-19 04:38:14 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 9 months ago (2015-03-19 10:24:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010683003/1
5 years, 9 months ago (2015-03-19 10:24:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 12:43:06 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:43:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8213be1a06f364feb2930bb33e530d007477f509
Cr-Commit-Position: refs/heads/master@{#27302}

Powered by Google App Engine
This is Rietveld 408576698