Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1010673005: Oilpan: promptly release FilterData on LayoutSVGResourceFilter destruction (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken, fs
CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, Dominik Röttsches, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: promptly release FilterData on LayoutSVGResourceFilter destruction For Oilpan, mirror the prompt release of the resources attached to FilterData, instead of leaving it until the next GC strikes. R=haraken,fs@opera.com BUG=467542 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191921

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M Source/core/layout/svg/LayoutSVGResourceFilter.h View 2 chunks +5 lines, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGResourceFilter.cpp View 6 chunks +22 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look. Speculative&blind attempt at addressing https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Win_Oilpan__dbg_/19/layout-test-results/virtual/slimmingpaint/svg/filters/filter-repaint-crash-log.txt (http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fslimmingpaint%2Fsvg%2Ffilters%2Ffilter-repaint.html) which needs to be resolved ...
5 years, 9 months ago (2015-03-16 10:52:00 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-16 10:53:08 UTC) #3
fs
lgtm
5 years, 9 months ago (2015-03-16 11:46:46 UTC) #5
sof
thanks, will land to gauge (oilpan-only) effect. Created crbug.com/467542 to track the issue.
5 years, 9 months ago (2015-03-16 14:39:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010673005/1
5 years, 9 months ago (2015-03-16 14:39:35 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 14:42:31 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191921

Powered by Google App Engine
This is Rietveld 408576698