Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1010653003: Remove android_webview_build conditions from base. (Closed)

Created:
5 years, 9 months ago by Torne
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove android_webview_build conditions from base. Remove references to android_webview_build now that we no longer support that build configuration. Fold all conditions into the general OS==android sections. BUG=440793 Committed: https://crrev.com/7aba6ac8106b2ff684fe06fc7197393dcd7a6965 Cr-Commit-Position: refs/heads/master@{#322087}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -39 lines) Patch
M base/android/linker/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gyp View 4 chunks +14 lines, -31 lines 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Torne
5 years, 9 months ago (2015-03-24 20:51:38 UTC) #2
Nico
lgtm
5 years, 9 months ago (2015-03-24 21:10:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010653003/1
5 years, 9 months ago (2015-03-24 21:48:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 23:04:42 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 23:05:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7aba6ac8106b2ff684fe06fc7197393dcd7a6965
Cr-Commit-Position: refs/heads/master@{#322087}

Powered by Google App Engine
This is Rietveld 408576698