Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 1010633002: Fix poblems found by PREfast. (Closed)

Created:
5 years, 9 months ago by Roger Tawa OOO till Jul 10th
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix problems found by PREfast. BUG=427616 Committed: https://crrev.com/cccd208c8ce7f60912c8049fc442d4ee957bef2e Cr-Commit-Position: refs/heads/master@{#320747}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Roger Tawa OOO till Jul 10th
Hi Bruce, Please take a look. Thanks.
5 years, 9 months ago (2015-03-16 01:09:52 UTC) #2
brucedawson
I verified through manual inspection augmented with 'find' that this change won't change the behavior ...
5 years, 9 months ago (2015-03-16 16:49:33 UTC) #3
Roger Tawa OOO till Jul 10th
Hi Mike, Please take a look. Thanks.
5 years, 9 months ago (2015-03-16 17:11:52 UTC) #5
Mike Lerman
On 2015/03/16 17:11:52, Roger Tawa wrote: > Hi Mike, > > Please take a look. ...
5 years, 9 months ago (2015-03-16 17:12:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010633002/20001
5 years, 9 months ago (2015-03-16 17:13:55 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-16 17:44:00 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 17:45:31 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cccd208c8ce7f60912c8049fc442d4ee957bef2e
Cr-Commit-Position: refs/heads/master@{#320747}

Powered by Google App Engine
This is Rietveld 408576698