Add browser test for AEC dump.

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 196 matching lines @@
       file_path,
       base::PLATFORM_FILE_CREATE_ALWAYS | base::PLATFORM_FILE_WRITE,
       NULL,
       &error);
   if (error != base::PLATFORM_FILE_OK) {
     VLOG(1) << "Could not open AEC dump file, error=" << error;
     return IPC::InvalidPlatformFileForTransit();
   }
   return IPC::GetFileHandleForProcess(aec_dump_file, process, true);
 }
+
+// Does nothing. Just to avoid races between enable and disable.
+void DisableAecDumpOnFileThread() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+}
+
 #endif
 
 // the global list of all renderer processes
 base::LazyInstance<IDMap<RenderProcessHost> >::Leaky
     g_all_hosts = LAZY_INSTANCE_INITIALIZER;
 
 base::LazyInstance<scoped_refptr<BrowserPluginGeolocationPermissionContext> >
     g_browser_plugin_geolocation_context = LAZY_INSTANCE_INITIALIZER;
 
 // Map of site to process, to ensure we only have one RenderProcessHost per
@@ skipping 1282 matching lines @@
 #if defined(ENABLE_WEBRTC)
 void RenderProcessHostImpl::EnableAecDump(const base::FilePath& file) {
   BrowserThread::PostTaskAndReplyWithResult(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&CreateAecDumpFileForProcess, file, GetHandle()),
       base::Bind(&RenderProcessHostImpl::SendAecDumpFileToRenderer,
                  weak_factory_.GetWeakPtr()));
 }
 
 void RenderProcessHostImpl::DisableAecDump() {
-  Send(new MediaStreamMsg_DisableAecDump());
+  BrowserThread::PostTaskAndReply(
+      BrowserThread::FILE, FROM_HERE,
+      base::Bind(&DisableAecDumpOnFileThread),

[phoglund_chromium, 2013/12/18 14:20:46]

So you queue something on the file thread just to make sure it has processed all
previous requests?

[Henrik Grunell, 2013/12/19 08:43:14]

Exactly. I don't know if there's another way that's common or better. This will
at least for sure avoid races, though it's kind of weird to just post back and
forth and do nothing on the file thread.

Added comment to clarify.

[phoglund_chromium, 2013/12/19 11:57:04]

I think it kind of makes sense. I can't think of a better way spontanously.

+      base::Bind(&RenderProcessHostImpl::SendDisableAecDumpToRenderer,
+                 weak_factory_.GetWeakPtr()));
 }
 #endif
 
 IPC::ChannelProxy* RenderProcessHostImpl::GetChannel() {
   return channel_.get();
 }
 
 void RenderProcessHostImpl::AddFilter(BrowserMessageFilter* filter) {
   channel_->AddFilter(filter->GetFilter());
 }
@@ skipping 423 matching lines @@
   }
 }
 
 #if defined(ENABLE_WEBRTC)
 void RenderProcessHostImpl::SendAecDumpFileToRenderer(
     IPC::PlatformFileForTransit file_for_transit) {
   if (file_for_transit == IPC::InvalidPlatformFileForTransit())
     return;
   Send(new MediaStreamMsg_EnableAecDump(file_for_transit));
 }
+
+void RenderProcessHostImpl::SendDisableAecDumpToRenderer() {
+  Send(new MediaStreamMsg_DisableAecDump());
+}
 #endif
 
 }  // namespace content