Add browser test for AEC dump.

content/renderer/media/media_stream_dependency_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/media_stream_dependency_factory.h"
 
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 654 matching lines @@
   pc_factory_ = factory;
   webrtc::PeerConnectionFactoryInterface::Options factory_options;
   factory_options.disable_sctp_data_channels =
       cmd_line->HasSwitch(switches::kDisableSCTPDataChannels);
   factory_options.disable_encryption =
       cmd_line->HasSwitch(switches::kDisableWebRtcEncryption);
   pc_factory_->SetOptions(factory_options);
 
   // |aec_dump_file| will be invalid when dump is not enabled.
   if (aec_dump_file_ != base::kInvalidPlatformFileValue) {
-    FILE* aec_dump_file_stream = base::FdopenPlatformFile(aec_dump_file_, "w");
-    if (!aec_dump_file_stream) {
-      VLOG(1) << "Could not open AEC dump file.";
-      base::ClosePlatformFile(aec_dump_file_);
-    } else {
-      // |pc_factory_| takes ownership of |aec_dump_file_stream|.
-      pc_factory_->StartAecDump(aec_dump_file_stream);
-    }
+    StartAecDump(aec_dump_file_);
     aec_dump_file_ = base::kInvalidPlatformFileValue;
   }
 
   return true;
 }
 
 bool MediaStreamDependencyFactory::PeerConnectionFactoryCreated() {
   return pc_factory_.get() != NULL;
 }
 
@@ skipping 327 matching lines @@
     IPC_MESSAGE_HANDLER(MediaStreamMsg_EnableAecDump, OnAecDumpFile)
     IPC_MESSAGE_HANDLER(MediaStreamMsg_DisableAecDump, OnDisableAecDump)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 void MediaStreamDependencyFactory::OnAecDumpFile(
     IPC::PlatformFileForTransit file_handle) {
   DCHECK_EQ(aec_dump_file_, base::kInvalidPlatformFileValue);
-  aec_dump_file_ = IPC::PlatformFileForTransitToPlatformFile(file_handle);
-  DCHECK_NE(aec_dump_file_, base::kInvalidPlatformFileValue);
+  if (PeerConnectionFactoryCreated()) {
+    base::PlatformFile file =
+        IPC::PlatformFileForTransitToPlatformFile(file_handle);
+    DCHECK_NE(file, base::kInvalidPlatformFileValue);
+    StartAecDump(file);
+  } else {
+    aec_dump_file_ = IPC::PlatformFileForTransitToPlatformFile(file_handle);
+    DCHECK_NE(aec_dump_file_, base::kInvalidPlatformFileValue);
+  }
 }
 
 void MediaStreamDependencyFactory::OnDisableAecDump() {
   if (aec_dump_file_ != base::kInvalidPlatformFileValue)
     base::ClosePlatformFile(aec_dump_file_);
   aec_dump_file_ = base::kInvalidPlatformFileValue;
 }
 
+void MediaStreamDependencyFactory::StartAecDump(
+    const base::PlatformFile& aec_dump_file) {
+  FILE* aec_dump_file_stream = base::FdopenPlatformFile(aec_dump_file, "w");
+  if (!aec_dump_file_stream) {
+    VLOG(1) << "Could not open AEC dump file.";
+    base::ClosePlatformFile(aec_dump_file);
+  } else {
+    // |pc_factory_| takes ownership of |aec_dump_file_stream|.
+    pc_factory_->StartAecDump(aec_dump_file_stream);
+  }
+}
+
 }  // namespace content