Add browser test for AEC dump.

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 196 matching lines @@
       file_path,
       base::PLATFORM_FILE_CREATE_ALWAYS | base::PLATFORM_FILE_WRITE,
       NULL,
       &error);
   if (error != base::PLATFORM_FILE_OK) {
     VLOG(1) << "Could not open AEC dump file, error=" << error;
     return IPC::InvalidPlatformFileForTransit();
   }
   return IPC::GetFileHandleForProcess(aec_dump_file, process, true);
 }
+
+// Does nothing. Just to avoid races between enable and disable.
+void DisableAecDumpOnFileThread() {
+  DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+}
+
 #endif
 
 // the global list of all renderer processes
 base::LazyInstance<IDMap<RenderProcessHost> >::Leaky
     g_all_hosts = LAZY_INSTANCE_INITIALIZER;
 
 base::LazyInstance<scoped_refptr<BrowserPluginGeolocationPermissionContext> >
     g_browser_plugin_geolocation_context = LAZY_INSTANCE_INITIALIZER;
 
 // Map of site to process, to ensure we only have one RenderProcessHost per
@@ skipping 1282 matching lines @@
 #if defined(ENABLE_WEBRTC)
 void RenderProcessHostImpl::EnableAecDump(const base::FilePath& file) {
   BrowserThread::PostTaskAndReplyWithResult(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&CreateAecDumpFileForProcess, file, GetHandle()),
       base::Bind(&RenderProcessHostImpl::SendAecDumpFileToRenderer,
                  weak_factory_.GetWeakPtr()));
 }
 
 void RenderProcessHostImpl::DisableAecDump() {
-  Send(new MediaStreamMsg_DisableAecDump());
+  // Posting on the FILE thread and then replying back on the UI thread is only
+  // for avoiding races between enable and disable. Nothing is done on the FILE
+  // thread.
+  BrowserThread::PostTaskAndReply(
+      BrowserThread::FILE, FROM_HERE,
+      base::Bind(&DisableAecDumpOnFileThread),

[jochen (gone - plz use gerrit), 2013/12/19 12:41:06]

would it be enough to create an empty base::Closure()?

[Henrik Grunell, 2013/12/19 13:46:10]

Well, it just crashes for me. Is that supposed to work?

+      base::Bind(&RenderProcessHostImpl::SendDisableAecDumpToRenderer,
+                 weak_factory_.GetWeakPtr()));
 }
 #endif
 
 IPC::ChannelProxy* RenderProcessHostImpl::GetChannel() {
   return channel_.get();
 }
 
 void RenderProcessHostImpl::AddFilter(BrowserMessageFilter* filter) {
   channel_->AddFilter(filter->GetFilter());
 }
@@ skipping 427 matching lines @@
   }
 }
 
 #if defined(ENABLE_WEBRTC)
 void RenderProcessHostImpl::SendAecDumpFileToRenderer(
     IPC::PlatformFileForTransit file_for_transit) {
   if (file_for_transit == IPC::InvalidPlatformFileForTransit())
     return;
   Send(new MediaStreamMsg_EnableAecDump(file_for_transit));
 }
+
+void RenderProcessHostImpl::SendDisableAecDumpToRenderer() {
+  Send(new MediaStreamMsg_DisableAecDump());
+}
 #endif
 
 }  // namespace content