Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Issue 1010623002: cc: remove useless forward_begin_frames_to_children flags in SchedulerSettings (Closed)

Created:
5 years, 9 months ago by simonhong
Modified:
5 years, 9 months ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: remove useless forward_begin_frames_to_children flags in SchedulerSettings This flag is not used. Instead, SetChildrenNeedBeginFrames() will be used to control child compositor's frame scheduling. R=brianderson@chromium.org BUG=467416 TEST=cc_unittests Committed: https://crrev.com/ddd3ce180015e8f3ec7509af1d5566778a10ca6d Cr-Commit-Position: refs/heads/master@{#320734}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M cc/scheduler/scheduler.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/scheduler/scheduler_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/scheduler/scheduler_settings.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
simonhong
PTAL.
5 years, 9 months ago (2015-03-15 22:47:49 UTC) #1
brianderson
lgtm
5 years, 9 months ago (2015-03-16 15:32:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1010623002/1
5 years, 9 months ago (2015-03-16 15:36:51 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 16:17:53 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 16:18:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddd3ce180015e8f3ec7509af1d5566778a10ca6d
Cr-Commit-Position: refs/heads/master@{#320734}

Powered by Google App Engine
This is Rietveld 408576698